NullPointerException in reactor-netty SniProvider when SSL bundle uses client-auth or server truststore without server-name-bundles#50301
Open
kwondh5217 wants to merge 1 commit into
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
kwondh5217
force-pushed
the
fix/50246-sni-fallback
branch
from
5519425 to
5e0d655
Compare
kwondh5217
changed the title
Signed-off-by: Daeho Kwon <trewq231@naver.com>
kwondh5217
force-pushed
the
fix/50246-sni-fallback
branch
from
5e0d655 to
3f6a910
Compare
wilkinsona
added
type: bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Falls back to the default
SslProviderwhen the SNI hostname is notpresent in
server-name-bundles. The lookup logic is extracted intoa package-private
getSslProvider(String)method to make it directlytestable.
A unit test is used instead of an end-to-end test because the
synchronous SNI lookup exception is silently swallowed inside Netty's
SslClientHelloHandler and the handshake falls back to the default
SslContext, so the NPE does not surface at the response level
(see netty/netty#16794).
Closes gh-50246